Remove duplicate metrics increment #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
monitoring
StephenButtolph
requested review from
danlaine,
darioush and
dboehm-avalabs
as code owners
JacobEverly
approved these changes
Apr 9, 2024
dhrubabasu
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This metric doesn't currently make much sense. We have two intermediate node caches. For the metrics, we should either split the metrics to report the usefulness of the caches independently, or we should treat the caches as a single cache for the metrics.
Specifically, fetching an intermediate node may:
This PR takes the (simpler) approach, of just treating the caches as a single cache. Now fetching an intermediate node will either:
How this works
Removes the duplicate cache miss call.
How this was tested
N/A