[tmpnet] Add network reuse to e2e fixture #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
tmpnet-reuse
branch
4 times, most recently
from
30ddbc6
to
8233457
Compare
3 tasks
Previously, using an existing network with the e2e suite required starting the network with the tmpnetctl cli. This has been replaced with direct support for network reuse within the e2e fixture to better support testing of networks with subnets and remove the need for other repos (subnet-evm and hypersdk) to use tmpnetctl: - Replace the --use-existing-network flag with --reuse-network flag which will ensure that a suite-compatible network is started if not already running and reused if already running - Added the --stop-network flag to support stopping a network previously started by --reuse-network and exiting immediately without running tests. tmpnetctl is left in place for now but its future is uncertain.
darioush
approved these changes
Apr 10, 2024
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: marun <maru.newby@avalabs.org>
StephenButtolph
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously, using an existing network with the e2e suite required starting the network with the tmpnetctl cli. This has been replaced with direct support for network reuse within the e2e fixture to better support testing of networks with subnets and remove the need for other repos (subnet-evm and hypersdk) to use tmpnetctl.
How this works
Replace the --use-existing-network flag with --reuse-network flag which will ensure that a suite-compatible network is started if not already running and reused if already running
Added the --stop-network flag to support stopping a network previously started by --reuse-network and exiting immediately without running tests.
tmpnetctl is left in place for now but its future is uncertain.
How this was tested