Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ManuallyTrack into ManuallyTrack and ManuallyGossip #2940

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Split ManuallyTrack into ManuallyTrack and ManuallyGossip #2940

merged 3 commits into from
Apr 16, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

  1. This fixes a small inaccuracy when users specify custom bootstrappers. Custom bootstrappers should not be gossiped unless they are validators.
  2. This allows us to specify an initial validator set that the node is willing to connect to but not introduce persistent bandwidth to the network.

How this works

Splits ManuallyTrack (which would treat provided IDs as validators) into ManuallyTrack (is willing to connect) and ManuallyGossip (is willing to connect and gossip).

How this was tested

  • Added unit tests
  • CI

@StephenButtolph StephenButtolph added the networking This involves networking label Apr 12, 2024
@StephenButtolph StephenButtolph added this to the v1.11.5 milestone Apr 12, 2024
@StephenButtolph StephenButtolph self-assigned this Apr 12, 2024
aaronbuchwald
aaronbuchwald approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one question

network/network.go Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Apr 16, 2024
Merged via the queue into master with commit 7975cb7 Apr 16, 2024
18 checks passed
@StephenButtolph StephenButtolph deleted the add-split-tracking-and-gossipping branch April 16, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbuchwald aaronbuchwald aaronbuchwald approved these changes

@joshua-kim joshua-kim joshua-kim approved these changes

@danlaine danlaine Awaiting requested review from danlaine danlaine is a code owner

Assignees

@StephenButtolph StephenButtolph

Labels
networking This involves networking
Projects
Platform Engineering Group
Archived in project
Milestone
v1.11.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StephenButtolph @joshua-kim @aaronbuchwald