Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dist/lib/avalanche.js in the bundle #97

Closed
harryEth opened this issue Sep 10, 2020 · 5 comments
Closed

Missing dist/lib/avalanche.js in the bundle #97

harryEth opened this issue Sep 10, 2020 · 5 comments

Comments

@harryEth
Copy link

In the package.json of avalanche (https://github.com/ava-labs/avalanche.js/blob/ab1d22ad5298c4e04fd17abad65316ef21e0f102/package.json#L6) the browser field refers to dist/lib/avalanche.js, but upon checking I don't think that folder exists. Only the dist folder exists, but it doesn't contain a lib folder: https://unpkg.com/browse/avalanche@2.4.3/dist/.

This is causing the issue(#89) and some env will not work well.

Can anyone help to fix this?

@collincusce
Copy link
Contributor

collincusce commented Sep 10, 2020

Yes it'll be fixed in the next release. We moved the bundle out of dist because it was causing import conflicts. It's now in web/avalanche.js . Thanks for pointing that out!

@collincusce
Copy link
Contributor

Does this fix codesandbox, by the way?

@harryEth
Copy link
Author

Does this fix codesandbox, by the way?

yes, it should fix the codesandbox.

@collincusce
Copy link
Contributor

We're planning on removing the "browser" property from the package.json entirely.

@harryEth
Copy link
Author

Thanks for solving this problem. Closing this.

dfenstermaker pushed a commit that referenced this issue Feb 22, 2023
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants