Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Add --uptime-requirement flag #97

Closed
wants to merge 4 commits into from
Closed

Add --uptime-requirement flag #97

wants to merge 4 commits into from

Conversation

cgcardona
Copy link
Contributor

This is the first flag which is a float. We need to confirm it's a float64 data type and that the strconv.FormatFloat call is correct.

"--uptime-requirement=" + strconv.FormatFloat(flags.UptimeRequirement, 'e', 10, 10),

@cgcardona cgcardona added the DO NOT MERGE Still a work in progress label Dec 22, 2020
@cgcardona cgcardona mentioned this pull request Dec 30, 2020
Open
aaronbuchwald
aaronbuchwald reviewed Jan 20, 2021
View reviewed changes
node/cli_tools.go Outdated Show resolved Hide resolved
@aaronbuchwald
Copy link
Collaborator

The uptime requirement is a float64, so the conversion looks correct.

@aaronbuchwald aaronbuchwald changed the base branch from master to dev January 20, 2021 18:08
@aaronbuchwald
Copy link
Collaborator

Addressed by #113

@cgcardona cgcardona deleted the add-uptime-requirement-flag branch February 28, 2021 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronbuchwald aaronbuchwald aaronbuchwald left review comments

Assignees
No one assigned
Labels
DO NOT MERGE Still a work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgcardona @aaronbuchwald