Drop outbound gossip requests for non-validators #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
requested review from
aaronbuchwald,
darioush and
ceyonur
as code owners
joshua-kim
changed the title
StephenButtolph
approved these changes
Sep 13, 2023
aaronbuchwald
approved these changes
Sep 13, 2023
dhrubabasu
approved these changes
Sep 13, 2023
darioush
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Added compatibility tracking * Added version moved test * Cleaned up test * Bump avalanchego version and nits * go mod tidy cmd/simulator * Mark trie clean jouranl test as flaky * Bump avalanchego to v1.9.2 * Bump anr version in scripts/versions.sh * Bump anr version in go.mod * go mod tidy cmd/simulator Co-authored-by: Aaron Buchwald <aaron.buchwald56@gmail.com>
darioush
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Add SDK Router message handling (#316) Co-authored-by: Stephen Buttolph <stephen@avalabs.org> * Fix hanging requests after Shutdown (#326) * fix requests hanging after shutdown * fix build --------- Signed-off-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> * Update to 1.10.10-rc.2 (#328) * update to avalanchego 1.10.10-rc.2 * nits * nit * Add P2P SDK Pull Gossip (#318) * add batchsize * sync changes * Drop outbound gossip for non vdrs (#862) * Drop outbound gossip requests for non-validators (#334) * drop outbound gossip requests for non validators * nit * nit * sync changes --------- Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> --------- Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Drops outbound requests for gossip
How this works
updates to new gossip package
How this was tested
This is tested in the upstream tests