Use better errors in wasmlanche-macros #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
force-pushed
the
improve-macro-errors
branch
from
a0f65c1
to
04fc321
Compare
richardpringle
force-pushed
the
improve-macro-errors
branch
2 times, most recently
from
6cb80f0
to
a11177f
Compare
darioush
previously approved these changes
Mar 7, 2024
richardpringle
force-pushed
the
improve-macro-errors
branch
3 times, most recently
from
c29e4be
to
8afae8d
Compare
richardpringle
force-pushed
the
improve-macro-errors
branch
from
8afae8d
to
ee0acaa
Compare
darioush
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be panicking in macros, it doesn't provide good error messages. Here are the error messages with the changes.
The above is just a (flawed) example. The actual errors are in the new
.stderrfiles.