add metrics pkg #110
Merged
add metrics pkg #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
approved these changes
May 24, 2022
There was a problem hiding this comment.
LGTM - let's hold off on merging this until #108 (review) has been merged, and then merge this into master.
| @@ -308,110 +324,115 @@ func (vm *VM) Initialize( | |||
| log.Warn("Chain enabled `AllowFeeRecipients`, but chain config has not specified any coinbase address. Defaulting to the blackhole address.") | |||
| } | |||
|
|
|||
| // Handle offline pruning | |||
There was a problem hiding this comment.
Just to confirm, this was just a duplicate block?
| vm.Network = peer.NewNetwork(appSender, vm.networkCodec, ctx.NodeID, vm.config.MaxOutboundActiveRequests) | ||
| vm.client = peer.NewClient(vm.Network) | ||
|
|
||
| if err := vm.initializeChain(lastAcceptedHash, ethConfig); err != nil { |
There was a problem hiding this comment.
nit: could put ethConfig on vm like Coreth.
There was a problem hiding this comment.
yeah I thought it but it's not being used anywhere. so just let those being garbage collected.
patrick-ogrady
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics pkg and enables metrics