Move warp payload to avalanchego #923
Merged
+59
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytzuga
force-pushed
the
move-warp-payload-to-avalanchego
branch
from
742ed5e
to
8bd462d
Compare
ceyonur
reviewed
Sep 29, 2023
nytzuga
changed the base branch from
master
to
warp-remove-destinationChainID-destinationAddress
|
@ceyonur done. |
darioush
reviewed
Sep 29, 2023
nytzuga
force-pushed
the
move-warp-payload-to-avalanchego
branch
from
db45c01
to
d74711b
Compare
ceyonur
added
the
DO NOT MERGE
|
I've added a DO NOT MERGE tag. We can remove once this is unblocked. |
nytzuga
force-pushed
the
move-warp-payload-to-avalanchego
branch
from
d74711b
to
e2f1728
Compare
nytzuga
force-pushed
the
warp-remove-destinationChainID-destinationAddress
branch
from
7d8eaa9
to
82e7cff
Compare
nytzuga
force-pushed
the
warp-remove-destinationChainID-destinationAddress
branch
2 times, most recently
from
fd00831
to
8d8de76
Compare
Base automatically changed from
warp-remove-destinationChainID-destinationAddress
to
master
October 3, 2023 19:54
nytzuga
force-pushed
the
move-warp-payload-to-avalanchego
branch
2 times, most recently
from
549f9f5
to
7261bfa
Compare
|
Converting to a draft until ava-labs/avalanchego#2116 is merged |
x/warp/contract_warp_handler.go
Outdated
| } | ||
| return PackGetVerifiedWarpMessageOutput(GetVerifiedWarpMessageOutput{ | ||
| Message: WarpMessage{ | ||
| SourceChainID: common.Hash(warpMessage.SourceChainID), | ||
| OriginSenderAddress: addressedPayload.SourceAddress, | ||
| Payload: addressedPayload.Payload, | ||
| OriginSenderAddress: common.BytesToAddress(addressedCall.SourceAddress), |
There was a problem hiding this comment.
Will make a follow up PR to switch from converting the bytes to an address to exposing the byte array directly to the caller and changing the Warp Solidity contract interface.
|
We can undraft this after #952 |
nytzuga
force-pushed
the
move-warp-payload-to-avalanchego
branch
from
a705b1f
to
05b25a0
Compare
nytzuga
force-pushed
the
move-warp-payload-to-avalanchego
branch
from
05b25a0
to
b08dcef
Compare
nytzuga
removed
the
DO NOT MERGE
|
@ceyonur @aaronbuchwald This is ready for another round of reviews |
ceyonur
approved these changes
Oct 12, 2023
abi87
reviewed
Oct 12, 2023
tests/warp/warp_test.go
Outdated
| @@ -21,6 +21,7 @@ import ( | |||
| "github.com/ava-labs/avalanchego/utils/crypto/bls" | |||
| "github.com/ava-labs/avalanchego/utils/set" | |||
| avalancheWarp "github.com/ava-labs/avalanchego/vms/platformvm/warp" | |||
| avalancheWarpPayload "github.com/ava-labs/avalanchego/vms/platformvm/warp/payload" | |||
There was a problem hiding this comment.
q: why we need the alias? Can't we use payload as package name?
abi87
approved these changes
Oct 12, 2023
anusha-ctrl
approved these changes
Oct 12, 2023
The alias is not longer needed
ceyonur
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This fixes ava-labs/avalanchego#2050 and ava-labs/avalanchego#2116
ava-labs/avalanchego#2116 and #920 should be merged before this PR
How this works
How this was tested
How is this documented