install avalanchego & subnetevm via avalanche-cli #392
Conversation
feuGeneA
force-pushed
the
feuGeneA/bin-deps-via-ava-cli
branch
from
3d955f0
to
c126f00
Compare
Signed-off-by: F. Eugene Aumson <feuGeneA@users.noreply.github.com>
feuGeneA
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
scripts/local/e2e_test.sh
Outdated
| export AVALANCHEGO_BUILD_PATH=${AVALANCHE_CLI_DIR}/bin/avalanchego/avalanchego-${AVALANCHEGO_VERSION} | ||
|
|
||
| # ensure that avalanche-cli has installed the version of avalanchego that we need: | ||
| if [[ ! -x "$AVALANCHEGO_BUILD_PATH/avalanchego" ]]; then | ||
| avalanche network clean | ||
| avalanche network start --avalanchego-version "$AVALANCHEGO_VERSION" | ||
| avalanche network clean | ||
| fi | ||
|
|
||
| # ensure that avalanche-cli has installed the version of subnetevm that we need: | ||
| subnetevm_bin=${AVALANCHE_CLI_DIR}/bin/subnet-evm/subnet-evm-${SUBNET_EVM_VERSION}/subnet-evm | ||
| if [[ ! -x "$subnetevm_bin" ]]; then | ||
| avalanche subnet create dummy --evm --vm-version "$SUBNET_EVM_VERSION" \ | ||
| --force \ | ||
| --teleporter --relayer --evm-chain-id 1 --evm-token DUM --evm-defaults # this line is just to avoid the dialog prompts | ||
| fi |
There was a problem hiding this comment.
Can you make the order of operations for these two consistent? I like
Path
Comment
if block
There was a problem hiding this comment.
addressed in 5c48264
There was a problem hiding this comment.
Does avalanche-cli have commands for directly installing the avalanchego and subnet-evm binaries? Manipulating the network just to install them seems like overkill and risks polluting or overwriting a user's avalanche-cli data.
I'm all for reducing the amount of bash we have to maintain, but am hesitant to do so if the alternative has additional overhead.
addresses review comment #392 (comment)
@cam-schultz No, Aat the time I submitted this I hadn't yet realized the distinction between avalanche-cli and avalanche-network-runner, and I was envisioning that we would be incorporating avalanche-cli usage into this repo anyways (especially given all the "migrate to avalanche-cli" wording in the issues tracked by #385). Given that perspective, I was thinking that, if we're going to be migrating to avalanche-cli anyways, then there'd be no hope of avoiding the polluting/overwriting of the user's avalanche-cli data anyways, so the scripts in this PR seemed acceptable in this regard. Having said all that, I'm happy to close this PR if that's what makes sense to the team. |
|
see also ava-labs/avalanche-cli#1938 |
| # This is a hack that can probably be undone when we stop setting up the | ||
| # avalanche network and subnet ourselves (via BeforeSuite/AfterSuite in | ||
| # tests/local/e2e_test.go) and start having avalanche-cli do that for us | ||
| # instead. |
There was a problem hiding this comment.
Since we're going to use the tempnet fixture rather than avalanche-cli for use in the Ginkgo E2E tests, this comment should probably be updated.
I think incorporating avalanche-cli directly could be overkill. It's a useful interface, but all we really need is the local network it spins up. The scenario I'm considering is one in which a user maintains a Fuji or mainnet subnet named |
|
We discussed this offline, and came to the conclusion that the ideal solution would be to add install scripts directly to subnet-evm and avalanchego, and leverage them directly in our repos. A standalone install command in the CLI would also work, but is less preferable because the CLI is downstream of teleporter, so leveraging that in our tests would create a circular dependency. Barring that, the consensus is that we should leave the install scripts as-is, rather than add the CLI as a dependency and potentially cause conflicts with other CLI usage. |
Why this should be merged
This eliminates the scripts in this repo that download and install avalanchego and subnetevm.
How this works
It uses avalanche-cli to download those things for us.
How this was tested
The e2e tests in CI now run with the avalanchego and subnetevm binaries downloaded and installed by CI.
How is this documented
In the root README.md and in
.github/workflows/test.yml.