AS-117: github issue 83 and 47 to handle truncated error messages #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will take care of the following github issues:
Earlier the error messages were truncated like the following:
"Client error:POST https://sandbox-rest.avatax.com/api/v2/transactions/createresulted in a401 Unauthorizedresponse:\n{\"error\": {\"code\": \"AuthenticationException\",\"message\": \"Authentication failed.\",\"details\": [{\"code\": \"AuthenticationExc (truncated...)\n"Post fix, the error message would look like the following:
"{\"error\": {\"code\": \"AuthenticationException\",\"message\": \"Authentication failed.\",\"details\": [{\"code\": \"AuthenticationException\",\"message\": \"Authentication failed.\",\"description\": \"Missing authentication or unable to authenticate the user or the account.\",\"faultCode\": \"Client\",\"helpLink\": \"http:\/\/developer.avalara.com\/avatax\/errors\/AuthenticationException\"}]}}"This was explained in detail here:
https://laracasts.com/discuss/channels/general-discussion/guzzle-error-message-gets-truncated?page=1&replyId=127348