Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in adding dem in probmap plot [ana4Stats] #855

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

awirb
Copy link
Contributor

@awirb awirb commented May 11, 2023

No description provided.

@awirb awirb requested a review from fso42 May 11, 2023 17:25
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (76e908e) 75.24% compared to head (7457f20) 75.24%.

❗ Current head 7457f20 differs from pull request most recent head 2694359. Consider uploading reports for the commit 2694359 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #855   +/-   ##
=======================================
  Coverage   75.24%   75.24%           
=======================================
  Files          62       62           
  Lines       13738    13756   +18     
=======================================
+ Hits        10337    10351   +14     
- Misses       3401     3405    +4     
Impacted Files Coverage Δ
avaframe/out3Plot/statsPlots.py 24.80% <25.00%> (+0.50%) ⬆️
avaframe/ana4Stats/probAna.py 91.27% <76.92%> (-0.67%) ⬇️
avaframe/com1DFA/deriveParameterSet.py 77.67% <100.00%> (ø)
avaframe/in3Utils/geoTrans.py 93.60% <100.00%> (ø)
avaframe/out3Plot/outQuickPlot.py 93.25% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

avaframe/ana4Stats/probAna.py Show resolved Hide resolved
avaframe/ana4Stats/probAna.py Show resolved Hide resolved
@fso42 fso42 added the bug Something isn't working label May 15, 2023
@fso42 fso42 added this to the Version 1.6 milestone May 15, 2023
@fso42 fso42 changed the title fix bug in adding dem in probmap plot fix bug in adding dem in probmap plot [ana4Stats] May 15, 2023
avaframe/ana4Stats/probAna.py Outdated Show resolved Hide resolved
@awirb awirb requested a review from fso42 May 15, 2023 11:05
@fso42 fso42 self-assigned this May 22, 2023
  - fix plot extent use linspace not arange
  - simplify warnings
  - fix cross profile plot for quick plot
  - set axes equal in probmap
@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit 2694359 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

The test coverage on the diff in this pull request is 80.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.2% (0.0% change).

View more on Code Climate.

@fso42
Copy link
Contributor

fso42 commented May 22, 2023

Standardtests ok

@fso42 fso42 merged commit 5ce549c into master May 22, 2023
6 checks passed
@fso42 fso42 deleted the fixProbMap branch May 22, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants