Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use relthFile if relThFromFile true [com1] #888

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

awirb
Copy link
Contributor

@awirb awirb commented Jul 20, 2023

  • if relThfile found in Inputs/RELTH it was used to set release thickness - should only be used if relThFromFile in cfg is set to True

also include a warning if there were particles exiting the domain at the end of the run and give the number of exited particles

@awirb awirb requested a review from fso42 July 20, 2023 08:49
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05% ⚠️

Comparison is base (061630f) 75.21% compared to head (3ab275f) 75.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
- Coverage   75.21%   75.17%   -0.05%     
==========================================
  Files          62       62              
  Lines       13824    13833       +9     
==========================================
+ Hits        10398    10399       +1     
- Misses       3426     3434       +8     
Files Changed Coverage Δ
avaframe/com1DFA/deriveParameterSet.py 77.67% <0.00%> (ø)
avaframe/in1Data/getInput.py 94.46% <40.00%> (-1.12%) ⬇️
avaframe/com1DFA/particleTools.py 57.06% <50.00%> (-0.04%) ⬇️
avaframe/com1DFA/com1DFA.py 92.52% <75.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fso42 fso42 added the enhancement New feature or request label Aug 7, 2023
@fso42 fso42 added this to the Version 1.6 milestone Aug 7, 2023
@fso42 fso42 self-assigned this Aug 8, 2023
@fso42 fso42 changed the title only use relthFile if relThFromFile true only use relthFile if relThFromFile true [com1DFA] Aug 8, 2023
@fso42 fso42 changed the title only use relthFile if relThFromFile true [com1DFA] only use relthFile if relThFromFile true [com1] Aug 8, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit 3ab275f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 50.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.1% (-0.1% change).

View more on Code Climate.

@fso42 fso42 merged commit bf0c24e into master Aug 8, 2023
5 of 6 checks passed
@fso42 fso42 deleted the fixRelThFromFile branch August 8, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants