allow to pass dem [ana3] #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
awirb
commented
Sep 8, 2023
awirb
commented
- pass path to dem
- if two sims to compare but not all three result variables provided still create plot
fso42
requested changes
Sep 11, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #905 +/- ##
==========================================
- Coverage 73.50% 73.49% -0.02%
==========================================
Files 63 63
Lines 14473 14478 +5
==========================================
+ Hits 10639 10641 +2
- Misses 3834 3837 +3
☔ View full report in Codecov by Sentry. |
fso42
approved these changes
Sep 13, 2023
|
Code Climate has analyzed commit 87a3a65 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 60.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.4%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.