Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update thalweg plot to compute average for bars #917

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

awirb
Copy link
Contributor

@awirb awirb commented Sep 21, 2023

No description provided.

@awirb awirb requested a review from fso42 September 21, 2023 10:52
@pep8speaks
Copy link

pep8speaks commented Sep 21, 2023

Hello @awirb! Thanks for updating this PR.

Line 1326:49: W292 no newline at end of file
Line 1308:46: E251 unexpected spaces around keyword / parameter equals
Line 1308:44: E251 unexpected spaces around keyword / parameter equals
Line 1301:39: E225 missing whitespace around operator
Line 1294:121: E501 line too long (133 > 120 characters)
Line 1286:121: E501 line too long (148 > 120 characters)
Line 1286:76: E251 unexpected spaces around keyword / parameter equals
Line 1277:5: E303 too many blank lines (2)
Line 1221:121: E501 line too long (167 > 120 characters)
Line 1189:6: E116 unexpected indentation (comment)
Line 1189:6: E114 indentation is not a multiple of four (comment)
Line 1167:58: E231 missing whitespace after ','
Line 1167:54: E231 missing whitespace after ','
Line 1094:22: E261 at least two spaces before inline comment
Line 1008:37: E225 missing whitespace around operator
Line 973:55: E225 missing whitespace around operator

Line 303:36: E231 missing whitespace after ','
Line 302:37: E231 missing whitespace after ','
Line 297:23: E231 missing whitespace after ','
Line 201:121: E501 line too long (129 > 120 characters)
Line 96:121: E501 line too long (124 > 120 characters)

Comment last updated at 2023-09-21 13:02:18 UTC

@fso42 fso42 added the enhancement New feature or request label Sep 21, 2023
@fso42 fso42 added this to the Version 1.7 milestone Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (21e0779) 73.65% compared to head (8acb4a0) 73.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   73.65%   73.66%   +0.01%     
==========================================
  Files          63       63              
  Lines       14551    14560       +9     
==========================================
+ Hits        10717    10726       +9     
  Misses       3834     3834              
Files Changed Coverage Δ
avaframe/out3Plot/outAIMEC.py 81.28% <100.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fso42 fso42 self-assigned this Sep 21, 2023
  - set threhsold for pytest and check length of averaged arrays
@codeclimate
Copy link

codeclimate bot commented Sep 21, 2023

Code Climate has analyzed commit 8acb4a0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.6% (0.0% change).

View more on Code Climate.

@fso42 fso42 merged commit 1632559 into master Sep 21, 2023
6 checks passed
@fso42 fso42 deleted the updateAimecDocu branch September 21, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants