Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add com6 rock avalanche [com6] #939

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Add com6 rock avalanche [com6] #939

merged 3 commits into from
Nov 30, 2023

Conversation

fso42
Copy link
Contributor

@fso42 fso42 commented Nov 16, 2023 •
edited

This adds a com6RockAvalanche similar to com5, i.e. an override setup for com1DFA; fixes #915

  • Add docu
  • Add simple test
  • add pytests

@fso42 fso42 added the enhancement New feature or request label Nov 16, 2023
@fso42 fso42 added this to the Version 1.8 milestone Nov 16, 2023
@fso42 fso42 self-assigned this Nov 16, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fce3bdf) 73.93% compared to head (8393918) 74.66%.

❗ Current head 8393918 differs from pull request most recent head ec7dfe5. Consider uploading reports for the commit ec7dfe5 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   73.93%   74.66%   +0.73%     
==========================================
  Files          63       64       +1     
  Lines       14618    14629      +11     
==========================================
+ Hits        10808    10923     +115     
+ Misses       3810     3706     -104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fso42 fso42 force-pushed the addCom6RockAvalanche branch 2 times, most recently from e8fa3b5 to 0a80aac Compare November 22, 2023 12:26
@pep8speaks
Copy link

pep8speaks commented Nov 23, 2023 •
edited

Hello @fso42! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-30 13:19:13 UTC

@fso42 fso42 requested a review from awirb November 23, 2023 13:37
@fso42 fso42 linked an issue Nov 24, 2023 that may be closed by this pull request
Add comXFois for rockfall testing #915
Closed
awirb
awirb requested changes Nov 28, 2023
View reviewed changes
avaframe/com6RockAvalanche/com6RockAvalanche.py Show resolved Hide resolved
avaframe/com6RockAvalanche/com6RockAvalancheCfg.ini Outdated Show resolved Hide resolved
avaframe/runCom6RockAvalanche.py Outdated Show resolved Hide resolved
docs/connector.rst Show resolved Hide resolved
@fso42 fso42 requested a review from awirb November 28, 2023 19:04
@fso42
Copy link
Contributor Author

fso42 commented Nov 29, 2023

Standardtests ok (basically ident)

@fso42
fix failing github action in outPlotAllPeak
ec7dfe5 
add comment back in; squash

fishing in the dark...; squash
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 30, 2023

Code Climate has analyzed commit ec7dfe5 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.6% (0.6% change).

View more on Code Climate.

@fso42 fso42 merged commit 4ec4c4a into master Nov 30, 2023
4 checks passed
@fso42 fso42 deleted the addCom6RockAvalanche branch November 30, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@awirb awirb Awaiting requested review from awirb

Assignees

@fso42 fso42

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.8
Development

Successfully merging this pull request may close these issues.

Add comXFois for rockfall testing
3 participants
@fso42 @pep8speaks @awirb