Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in figure legend #958

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix bug in figure legend #958

merged 1 commit into from
Jan 31, 2024

Conversation

awirb
Copy link
Contributor

@awirb awirb commented Jan 29, 2024

No description provided.

@awirb awirb requested a review from fso42 January 29, 2024 11:49
@pep8speaks
Copy link

Hello @awirb! Thanks for opening this PR.

Line 165:48: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Do see the Hitchhiker's guide to code style

Copy link

codeclimate bot commented Jan 29, 2024

Code Climate has analyzed commit 2621f67 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.8% (0.0% change).

View more on Code Climate.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cb03fd) 73.88% compared to head (2621f67) 73.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files          64       64           
  Lines       14755    14755           
=======================================
  Hits        10901    10901           
  Misses       3854     3854           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fso42 fso42 self-assigned this Jan 31, 2024
@fso42 fso42 added the bug Something isn't working label Jan 31, 2024
@fso42 fso42 added this to the Version 1.8 milestone Jan 31, 2024
@fso42 fso42 merged commit 2d5ba44 into master Jan 31, 2024
6 checks passed
@fso42 fso42 deleted the fixBugPlot branch January 31, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants