Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal resizing #152

Merged
merged 7 commits into from
Jun 16, 2021

Conversation

uninhm
Copy link
Contributor

@uninhm uninhm commented May 31, 2021

No description provided.

@uninhm
Copy link
Contributor Author

uninhm commented May 31, 2021

#143

@avahe-kellenberger
Copy link
Owner

Just as a note, I tested it and it seems to be working very well.

The only edge case I see that need covering, is resizing too far. If you hold super l or super h too long you'll see Nimdow will crash

@uninhm
Copy link
Contributor Author

uninhm commented Jun 2, 2021

Sorry for the double commit, I thought I hadn't committed yet

@dakyskye
Copy link
Contributor

Works very well 👍 great job! However, I wish there was a way to reset that resize. Probably a keybinding for it, or automatically reset it when all slave windows get closed 🤷‍♂️

@avahe-kellenberger
Copy link
Owner

Let's make an issue for it, and implement it in another PR. I want to do a few renames and merge this in today.

@uninhm
Copy link
Contributor Author

uninhm commented Jun 13, 2021

Is there something I can do?

@avahe-kellenberger
Copy link
Owner

@uninhm See the comment(s) I left, small changes then I can merge

@uninhm
Copy link
Contributor Author

uninhm commented Jun 14, 2021

@avahe-kellenberger done

@avahe-kellenberger avahe-kellenberger merged commit 3185ec5 into avahe-kellenberger:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants