-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct spelling mistakes found by codespell. Fixes lathiat/avahi #167 #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spelling contributions in here. Needs to be changed for the following:
- don't fix typos in variable names that are (potentially) used to provide an external API to Avahi. Changing would break the binding/interface. Best do this in separate PRs where impact can be considered. See separate comments on code lines.
- don't fix typos in 'specs' folder - these are verbatim included IETF specs.
Revert also unrelated change to .gitignore
Allow any application to still work, even if they reference value with typo.
I have rebase it to current master, which fixed some places. Reverted the specs fixes and added backward compatible definition. @EskoDijk, what do you think about modified version? |
@pemensik Thanks, good backward compatible solution in the C code. So I would not include this C# change as part of a "typo fix clean sweep PR" like this one. |
Use trick mentioned at stackowerflow.com, non-unique-enum-values
@pemensik Thanks, that solves it. |
Fixes issue #167.