Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling mistakes found by codespell. Fixes lathiat/avahi #167 #222

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

warmsocks
Copy link

@warmsocks warmsocks commented Apr 17, 2019

Fixes issue #167.

@pemensik pemensik added the documentation Change of text outside of the code. label Nov 24, 2022
Copy link

@EskoDijk EskoDijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spelling contributions in here. Needs to be changed for the following:

  • don't fix typos in variable names that are (potentially) used to provide an external API to Avahi. Changing would break the binding/interface. Best do this in separate PRs where impact can be considered. See separate comments on code lines.
  • don't fix typos in 'specs' folder - these are verbatim included IETF specs.

.gitignore Outdated Show resolved Hide resolved
specs/draft-cheshire-dnsext-dns-sd-02.txt Outdated Show resolved Hide resolved
avahi-gobject/ga-entry-group.h Show resolved Hide resolved
avahi-sharp/EntryGroup.cs Show resolved Hide resolved
Shaun Case and others added 3 commits April 20, 2023 19:36
Revert also unrelated change to .gitignore
Allow any application to still work, even if they reference value with
typo.
@pemensik
Copy link
Member

I have rebase it to current master, which fixed some places. Reverted the specs fixes and added backward compatible definition. @EskoDijk, what do you think about modified version?

@EskoDijk
Copy link

@pemensik Thanks, good backward compatible solution in the C code.
However there is still a change in the API for C# code (consists of the two changes in the avahi-sharp directory). The enum item name is changed there in C# which causes any build using this library to break.
(C# doesn't have #define to fix that for us - although there are some tricks maybe to make it work see https://stackoverflow.com/questions/8043027/non-unique-enum-values )

So I would not include this C# change as part of a "typo fix clean sweep PR" like this one.

Use trick mentioned at stackowerflow.com, non-unique-enum-values
@pemensik pemensik merged commit a0cb004 into avahi:master Apr 21, 2023
@EskoDijk
Copy link

@pemensik Thanks, that solves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Change of text outside of the code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants