Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: build avahi on aarch64, i386, ppc64le, s390x, x86_64 on PRs #541

Merged
merged 1 commit into from
Feb 15, 2024
Merged

ci: build avahi on aarch64, i386, ppc64le, s390x, x86_64 on PRs #541

merged 1 commit into from
Feb 15, 2024

Conversation

evverx
Copy link
Member

@evverx evverx commented Dec 8, 2023 •
edited
Loading

@evverx evverx added the CI continuous integration or tests label Dec 8, 2023
@evverx evverx changed the title CI: build avahi on aarch64, i386, ppc64le, s390x, x86_64 on PRs ci: build avahi on aarch64, i386, ppc64le, s390x, x86_64 on PRs Dec 8, 2023
@evverx evverx force-pushed the packit branch 2 times, most recently from bf46062 to 2d5086d Compare December 8, 2023 07:15
pemensik
pemensik approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@pemensik pemensik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems nice. Do we have any avahi COPR repository already, where this can be tried?

@pemensik
Copy link
Member

pemensik commented Jan 3, 2024

From my team I am working in, only tuned uses packit in their upstream project. I were asked, why we do not use fedora-all in our proposal. Is there a specific reason for it?

@evverx evverx force-pushed the packit branch 2 times, most recently from 7b52a52 to 57cf854 Compare January 24, 2024 15:46
@evverx
Copy link
Member Author

evverx commented Jan 24, 2024

Do we have any avahi COPR repository already, where this can be tried?

It's built at https://copr.fedorainfracloud.org/coprs/packit/evverx-avahi-3/ regularly but the avahi repository itself hasn't been hooked up yet.

why we do not use fedora-all in our proposal. Is there a specific reason for it?

rawhide is kind of unstable (for example today one build failed on rawhide-i386: https://copr.fedorainfracloud.org/coprs/packit/evverx-avahi-3/build/6946551/) so it's easier to temporarily turn it off by commenting it out if it's mentioned explicitly. fedora-all should work too though.

@evverx
Copy link
Member Author

evverx commented Feb 15, 2024

I'll go ahead and merge it to make it easier for me to run those builds using my fork at least. Currently I have to cherry-pick this commit on top of PRs every time. It should still be hooked up but it's tracked in a separate issue. It still builds fine: https://copr.fedorainfracloud.org/coprs/packit/evverx-avahi-3/build/7018789/

@evverx evverx marked this pull request as ready for review February 15, 2024 02:22
@evverx evverx merged commit 6e226a7 into avahi:master Feb 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pemensik pemensik pemensik approved these changes

Assignees
No one assigned
Labels
CI continuous integration or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evverx @pemensik