Support GTK+ 4.0 #90
Open
Support GTK+ 4.0 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the existing GTK+ 2 and GTK+ 4 support.
However, there might be a simpler way: https://git.gnome.org/browse/gtk+/commit/?id=9a684accfea1b786d8a3b36d97f339ce0ea2e236
There doesn't seem to be any new way to easily have both a name and an icon. Presumably this is now discouraged as a design principle, though the commit message doesn't say so: https://git.gnome.org/browse/gtk+/commit/gtk/gtkbutton.c?id=be2f19663bf9c1ead35fa69aee0292842ceada97
This now takes no arguments.
This is now removed and unnecessary.
|
I rebased this PR on top of the master branch of my fork to trigger the CI. Looks like it fails to build |
|
Instead of an uber-project that contains the core and all the UI libraries, would it make sense to start pulling the UI libraries and graphical tools out of the core project? |
|
It's being discussed in #516 but nobody apart from NixOS and Debian has shown up yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits first avoid some deprecated API, then add a GTK4 version of avahi-ui, and then make some GTK4-specific changes.
I have not tested this at all and there doesn't seem to be any example/demo code for avahi-ui in the avahi repository itself.