Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize DI class imports #351

Merged
merged 2 commits into from
May 29, 2023
Merged

Sanitize DI class imports #351

merged 2 commits into from
May 29, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented May 25, 2023

On the discord, an issue was reported that something like this generates invalid adapters.

@Singleton
public class ServersService {
  ...
  public @Inject ServersService(final @NotNull JedisPool jedisPool, final @NotNull NatsConnection natsConnection) {
    this.jedisPool = jedisPool;
    this.natsConnection = natsConnection;
  }
  ...

the generated DI class has annotations in the imports causing compilation to fail.

I could not replicate the issue on my local, but I'm sure this'll fix it. (or else do absolutely nothing).

@SentryMan SentryMan changed the title Sanitize DI class imports. Sanitize DI class imports May 25, 2023
@SentryMan
Copy link
Collaborator Author

It seems like it may be an IntelliJ thing. I can't really replicate since I don't have.

@rbygrave rbygrave added this to the 9.3 milestone May 29, 2023
@rbygrave rbygrave merged commit c7bcab8 into avaje:master May 29, 2023
2 checks passed
@SentryMan SentryMan deleted the import branch May 29, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants