Exclude Blackbox Module from Lift #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we want this change? |
|
Because it's throwing off the bug reports? I mean I don't feel like fixing the sca issues of the black box test |
|
I can't find the Lift report detail that suggests this change (hence I don't know why it is suggesting this change). Can you include that here? This change does not make sense to me. It looks like a bad suggestion to me. |
|
Optional.empty doesn't create a new instance every time, so it's kinda redundant to define a second constant. Even so, I made this pr primarily to exclude the black box test module. |
This reverts commit 210126d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure lift to skip blackbox module