Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Generic type Params showing up in generated requires #356

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

SentryMan
Copy link
Collaborator

Got a request saying

I have a constructor injecting a MongoCollection param and the module has a requires for org.MongoDB.client.MongoCollection<org.Bson.Document>.class but it should be ignoring generics
that didn’t happen in earlier versions, haven’t narrowed it down to which inject version breaks it though

didn't get more than that but I think this should resolve it.

@rob-bygrave rob-bygrave added this to the 9.3 milestone Jun 21, 2023
@rob-bygrave rob-bygrave added the bug Something isn't working label Jun 21, 2023
@rob-bygrave rob-bygrave merged commit 51f4b81 into avaje:master Jun 21, 2023
3 checks passed
rob-bygrave added a commit that referenced this pull request Jun 21, 2023
rob-bygrave added a commit that referenced this pull request Jun 21, 2023
#356 - Test and refactor for - Fix Generic type Params showing up in generated requires
@SentryMan SentryMan deleted the genericRequires branch June 21, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants