Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module Validation #390

Merged
merged 8 commits into from
Aug 26, 2023
Merged

Module Validation #390

merged 8 commits into from
Aug 26, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Aug 25, 2023 •
edited

Now we can ensure module-info classes have the provides statement for the generated module classes.

Got around the ModuleElement limitations by using Filer to manually read the module-info.java file.

Fixes #389

@SentryMan SentryMan added the enhancement New feature or request label Aug 26, 2023
@SentryMan SentryMan added this to the 9.6 milestone Aug 26, 2023
@SentryMan SentryMan self-assigned this Aug 26, 2023
@rbygrave rbygrave merged commit 519c939 into avaje:master Aug 26, 2023
2 checks passed
@SentryMan SentryMan deleted the module-validation branch August 26, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave Awaiting requested review from rbygrave

Assignees

@SentryMan SentryMan

Labels
enhancement New feature or request
Projects
None yet
Milestone
9.7
Development

Successfully merging this pull request may close these issues.

Module-Info Validation
2 participants
@SentryMan @rbygrave