Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @Import Package-Private Constructors #397

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Support @Import Package-Private Constructors #397

merged 2 commits into from
Sep 3, 2023

Conversation

SentryMan
Copy link
Collaborator

For classpath-only applications, split packages are less of an issue.

Now can do this

@Component.Import(value = OtherComponent2.class, packagePrivate = true)

to make the generated DI classes for OtherComponent2 reside in the same package.

fixes #396

@SentryMan SentryMan self-assigned this Sep 2, 2023
@rbygrave rbygrave added this to the 9.6 milestone Sep 3, 2023
@rbygrave rbygrave merged commit d195749 into avaje:master Sep 3, 2023
2 checks passed
@SentryMan SentryMan deleted the packagePrivate branch September 3, 2023 19:41
rbygrave added a commit that referenced this pull request Sep 3, 2023
@rbygrave
Style only changes - Extract method with comment
10106ce 
Follow up for #397 #396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave Awaiting requested review from rbygrave

Assignees

@SentryMan SentryMan

Labels
None yet
Projects
None yet
Milestone
9.7
Development

Successfully merging this pull request may close these issues.

@Component.Import for classes with package private constructors
2 participants
@SentryMan @rbygrave