Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Annotation processing in JDK 22 #411

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

SentryMan
Copy link
Collaborator

It got disabled

@rbygrave rbygrave merged commit 688e4f8 into avaje:master Oct 16, 2023
3 checks passed
@SentryMan SentryMan deleted the jdk22 branch October 16, 2023 19:02
@SentryMan
Copy link
Collaborator Author

SentryMan commented Oct 16, 2023

I'm thinking it'll be easier in the long run to merely update the parent rather than modifying this in all the repos.

@rbygrave
Copy link
Contributor

Yes, agreed. I was just happy to merge it in to A) recognise your work there + include the README change and B) double check the EA build was all cool.

I think we now do another PR that uses the parent pom v3.12.

@rbygrave
Copy link
Contributor

Plus if people are looking at the git history then it's nice and explicit as to what was done to get the JDK 22 build to pass. The parent pom bump is going to be less obvious to other people.

@rbygrave rbygrave changed the title Enable Annotation processing in 22 Enable Annotation processing in JDK 22 Oct 16, 2023
@rbygrave rbygrave added this to the 9.8 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants