Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Conditional Beans not working with AOP #433

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix Conditional Beans not working with AOP #433

merged 1 commit into from
Oct 17, 2023

Conversation

SentryMan
Copy link
Collaborator

  • adds a new member to the @Proxy annotation to track the typemirror across rounds
  • will now read the proxy annotation values and read the bean conditions

fixes #432

@SentryMan SentryMan merged commit dfeea2b into avaje:master Oct 17, 2023
4 checks passed
@SentryMan SentryMan deleted the fix-aop branch October 17, 2023 23:59
rbygrave added a commit that referenced this pull request Oct 18, 2023
@rbygrave
#433 followup - Add test and update style on BeanReader
43fce85
@rbygrave rbygrave added this to the 9.8 milestone Oct 18, 2023
@rbygrave rbygrave added the bug Something isn't working label Oct 18, 2023
SentryMan added a commit that referenced this pull request Oct 18, 2023
@SentryMan
Merge pull request #434 from avaje/feature/433-followup
55c4394 
#433 followup - Add test and update style on BeanReader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave rbygrave approved these changes

Assignees

@SentryMan SentryMan

Labels
bug Something isn't working
Projects
None yet
Milestone
9.8
Development

Successfully merging this pull request may close these issues.

Conditional bean conditions are not respected on AOP proxy
2 participants
@SentryMan @rbygrave