Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#439 Handle case where Factory method throws exception #440

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Conversation

rbygrave
Copy link
Contributor

Adds a try catch block to the generated code

Adds a try catch block to the generated code
@rbygrave rbygrave self-assigned this Oct 24, 2023
@rbygrave rbygrave linked an issue Oct 24, 2023 that may be closed by this pull request
@rbygrave rbygrave added the bug Something isn't working label Oct 24, 2023
@SentryMan
Copy link
Collaborator

Can we also handle cases where method injection and constructors throw as well?

@rbygrave
Copy link
Contributor Author

method injection and constructors throw as well?

Ok, we have support for both of these now.

@SentryMan SentryMan merged commit d632f95 into master Oct 25, 2023
7 checks passed
@SentryMan SentryMan deleted the feature/439 branch October 25, 2023 03:46
@rob-bygrave rob-bygrave added this to the 9.9 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Declarative exception handling for @Factory or @Inject
3 participants