Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling NPE issue with latest org.jetbrains:annotations (from version 13.0 to 24.0.1) #447

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 26, 2023

Bumps org.jetbrains:annotations from 13.0 to 24.0.1.

Release notes

Sourced from org.jetbrains:annotations's releases.

24.0.1

  • Added @Documented annotation where it would be useful.

24.0.0

  • Added new annotation: @CheckReturnValue

23.1.0

  • Added new annotation: @ApiStatus.Obsolete

23.0.0

  • Added new annotations: @BlockingExecutor and @NonBlockingExecutor.

22.0.0

  • Added new annotations: @Blocking and @NonBlocking.

21.0.1

  • Multi-Release Jar: Manifest fixed

21.0.0

  • Added new annotation: @UnknownNullability.
  • Proper JPMS module.

20.1.0

  • Added TYPE_USE target for PropertyKey annotation.

20.0.0

  • Added new annotation: @MustBeInvokedByOverriders.
  • Added new annotation: @VisibleForTesting.
  • Added TYPE_USE target for NonNls annotation.
  • String attributes of annotations are marked as @NonNls where applicable.
  • Documentation for @Nls and @NonNls updated: now they could be used as meta-annotations.
  • Documentation added for @Subst annotation.

19.0.0

  • Added new annotations: @Unmodifiable and @UnmodifiableView.
  • Added TYPE_USE target for Nls annotation.
  • Improved the documentation for @Language, @Pattern, @RegExp, and @ApiStatus.Internal annotations.
  • Fixed Automatic-Module-Name for Java 5.

18.0.0

  • Added new annotation family @ApiStatus.*
  • Added new annotation @Debug.Renderer

17.0.0

  • Added new annotation: @Range

16.0.3

  • Added Automatic-Module-Name to MANIFEST.MF

16.0.2

... (truncated)

Changelog

Sourced from org.jetbrains:annotations's changelog.

Version 24.0.1

  • Added @Documented annotation where it would be useful.

Version 24.0.0

  • Added new annotation: @CheckReturnValue.

Version 23.1.0

  • Added new annotation: @ApiStatus.Obsolete.

Version 23.0.0

  • Added new annotations: @BlockingExecutor and @NonBlockingExecutor.

Version 22.0.0

  • Added new annotations: @Blocking and @NonBlocking.

Version 21.0.1

  • Multi-Release Jar: Manifest fixed

Version 21.0.0

  • Added new annotation: @UnknownNullability.
  • Proper JPMS module.
  • JdkConstants deprecated.

Version 20.1.0

  • Added TYPE_USE target for PropertyKey annotation.

Version 20.0.0

  • Added new annotation: @MustBeInvokedByOverriders.
  • Added new annotation: @VisibleForTesting.
  • Added TYPE_USE target for NonNls annotation.
  • String attributes of annotations are marked as @NonNls where applicable.
  • Documentation for @Nls and @NonNls updated: now they could be used as meta-annotations.
  • Documentation added for @Subst annotation.

Version 19.0.0

  • Added new annotations: @Unmodifiable and @UnmodifiableView.
  • Added TYPE_USE target for Nls annotation.
  • Improved the documentation for @Language, @Pattern, @RegExp, and @ApiStatus.Internal annotations.
  • Fixed Automatic-Module-Name for Java 5.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.jetbrains:annotations](https://github.com/JetBrains/java-annotations) from 13.0 to 24.0.1.
- [Release notes](https://github.com/JetBrains/java-annotations/releases)
- [Changelog](https://github.com/JetBrains/java-annotations/blob/master/CHANGELOG.md)
- [Commits](https://github.com/JetBrains/java-annotations/commits/24.0.1)

---
updated-dependencies:
- dependency-name: org.jetbrains:annotations
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 26, 2023
@rob-bygrave
Copy link
Contributor

The expected weirdness with that later version of org.jetbrains:annotations as predicted.

@SentryMan
Copy link
Collaborator

something to worry about?

@rob-bygrave
Copy link
Contributor

something to worry about?

Well I do wonder if this means it isn't going to work for projects that use Kotlin (that bring in this later version of this dependency).

It's a pretty freaky sort of issue. At this stage I'm thinking of just leaving this here for a few weeks and see if I get some time to look at it again then and maybe hoping some other project out there finds something about it.

@github-actions github-actions bot merged commit 4bf5ac1 into master Oct 27, 2023
7 checks passed
@dependabot dependabot bot deleted the dependabot/maven/org.jetbrains-annotations-24.0.1 branch October 27, 2023 02:36
@rbygrave rbygrave added this to the 9.9 milestone Oct 27, 2023
@rbygrave rbygrave changed the title Bump org.jetbrains:annotations from 13.0 to 24.0.1 Fix compiling NPE issue with latest org.jetbrains:annotations (from version 13.0 to 24.0.1) Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants