Fix Generic Junit Injection #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbygrave
reviewed
Nov 28, 2023
| @Test | ||
| void test() { | ||
| assertThat(intymcintface).isNotNull(); | ||
| } |
| @@ -49,7 +50,7 @@ static class HelloBean { | |||
|
|
|||
| static class MyPlugin implements Plugin { | |||
|
|
|||
| public boolean forType(Class<?> type) { | |||
| public boolean forType(Type type) { | |||
| * Return a single bean given its type and generic components. | ||
| * | ||
| * <pre>{@code | ||
| * Map<String, CoffeeMaker> coffeeMaker = beanScope.get(Map.class, String.class, CoffeeMaker.class); |
There was a problem hiding this comment.
This looks like extra functionality and not part of the bug fix?
Improve this example
| * @throws java.util.NoSuchElementException When no matching bean is found | ||
| */ | ||
| default <T> T get(@Nullable String name, Type type, Type... types) { | ||
|
|
There was a problem hiding this comment.
whitespace formatting
This looks like extra functionality unrelated to the bug fix.
| @@ -196,6 +197,12 @@ private <D> BeanScopeBuilder.ForTesting spy(Class<D> type, @Nullable String name | |||
| return this; | |||
| } | |||
|
|
|||
| private <D> BeanScopeBuilder.ForTesting spy( | |||
| Type type, @Nullable String name, @Nullable Consumer<D> consumer) { | |||
| private final Type rawType; | ||
| public final Type[] typeArguments; | ||
|
|
||
| public ParameterizedTypeImpl(Type ownerType, Type rawType, Type... typeArguments) { |
| } | ||
|
|
||
| /** Returns an array type whose elements are all instances of {@code componentType}. */ | ||
| public static GenericArrayType arrayOf(Type elementType) { |
| * Returns a new parameterized type, applying {@code typeArguments} to {@code rawType}. Use this | ||
| * method if {@code rawType} is not enclosed in another type. | ||
| */ | ||
| public static ParameterizedType newParameterizedType(Type rawType, Type... typeArguments) { |
|
|
||
| } else if (type instanceof ParameterizedType) { | ||
| ParameterizedType parameterizedType = (ParameterizedType) type; | ||
|
|
| return rawType(((WildcardType) type).getUpperBounds()[0]); | ||
|
|
||
| } else { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #461