For @InjectTest only build new BeanScope when test has mocks or spies #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, for each test using @InjectTest a new BeanScope is wired (and uses a parent scope with @TestScope beans in it). This changes, such that the "global test scope" is a pair of BeanScope with - "testBaseScope" as scope with all @TestScope beans in it - "testAllScope" as all beans (with the testBaseScope as its parent). Any test that just injects can reuse the "testAllScope" (and not write a new BeanScope). Any test that uses mocks, spies, has a setup method, or uses profiles must work as before and wire a new BeanScope (and as before use the "testBaseScope" as its parent). This change makes component testing faster
SentryMan
approved these changes
Feb 13, 2024
rbygrave
added a commit
that referenced
this pull request
Feb 19, 2024
- Rename GlobalTestScope -> GlobalTestBeans - Lift and rename GlobalTestScope.Pair to TestBeans - The plugin scope lives in TestBeans and scoped with the associated test bean scope (created together, closed together) - Rename PluginInitialise to PluginMgr - Rename TSBuild to GlobalInitialise Note the plugin for avaje-nima creates the nima http server, so now this will be started and stopped with the associated bean scope.
rbygrave
added a commit
that referenced
this pull request
Feb 19, 2024
- Rename GlobalTestScope -> GlobalTestBeans - Lift and rename GlobalTestScope.Pair to TestBeans - The plugin scope lives in TestBeans and scoped with the associated test bean scope (created together, closed together) - Rename PluginInitialise to PluginMgr - Rename TSBuild to GlobalInitialise Note the plugin for avaje-nima creates the nima http server, so now this will be started and stopped with the associated bean scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for each test using @InjectTest a new BeanScope is wired (and uses a parent scope with @TestScope beans in it).
This changes, such that the "global test scope" is a pair of BeanScope with
Any test that just injects can reuse the "testAllScope" (and not write a new BeanScope).
Any test that uses mocks, spies, has a setup method, or uses profiles must work as before and wire a new BeanScope (and as before use the "testBaseScope" as its parent).
This change makes component testing faster