fix: compilation error with providers and throws

[mohamed-abdelnour]

Hello, everyone! Thank you all for your work.

Avaje-Inject currently generates invalid code when a "provider" method (i.e. @Prototype, @Lazy, etc.) has a throws clause.

There are two problems:

1. a syntax error: try { ... } } catch.
2. the lambdas passed to Builder::register(Lazy|Provider) do not handle the declared Throwables.

This fixes those problems by wrapping the bodies of the lambdas passed to Builder::register(Lazy|Provider) in try blocks.

To demonstrate, here are the (relevant) differences in the generated code before and after applying the fix:

--- before-fix-fallible-providers/blackbox-test-inject/target/generated-sources/annotations/org/example/myapp/config/AppConfig$DI.java
+++ fix-fallible-providers/blackbox-test-inject/target/generated-sources/annotations/org/example/myapp/config/AppConfig$DI.java
@@ -71,15 +71,15 @@ public final class AppConfig$DI  {
   public static void build_newBuilderThrows(Builder builder) {
     if (builder.isAddBeanFor(AppConfig.BuilderThrows.class)) {
       var factory = builder.get(AppConfig.class);
+      builder.asPrototype()
+.registerProvider(() -> {
       try {
-        builder.asPrototype()
-  .registerProvider(() -> {
           return factory.newBuilderThrows();
-        });
-      }
       } catch (Throwable e) {
         throw new RuntimeException("Error during wiring", e);
       }
+      });
+    }
   }

   /**
@@ -112,15 +112,15 @@ public final class AppConfig$DI  {
   public static void build_generalSecondaryThrows(Builder builder) {
     if (builder.isAddBeanFor(AppConfig.MySecTypeThrows.class)) {
       var factory = builder.get(AppConfig.class);
+      builder.asSecondary()
+.registerProvider(() -> {
       try {
-        builder.asSecondary()
-  .registerProvider(() -> {
           return factory.generalSecondaryThrows();
-        });
-      }
       } catch (Throwable e) {
         throw new RuntimeException("Error during wiring", e);
       }
+      });
+    }
   }

   /**

--- before-fix-fallible-providers/blackbox-test-inject/target/generated-sources/annotations/org/example/myapp/lazy/LazyFactory$DI.java
+++ fix-fallible-providers/blackbox-test-inject/target/generated-sources/annotations/org/example/myapp/lazy/LazyFactory$DI.java
@@ -41,14 +41,14 @@ public final class LazyFactory$DI  {
   public static void build_lazyIntThrows(Builder builder) {
     if (builder.isAddBeanFor("factorythrows", LazyBean.class)) {
       var factory = builder.get(LazyFactory.class);
+      builder.registerLazy(() -> {
       try {
-        builder  .registerLazy(() -> {
           return factory.lazyIntThrows(builder.getNullable(AtomicBoolean.class,"!initialized"));
-        });
-      }
       } catch (Throwable e) {
         throw new RuntimeException("Error during wiring", e);
       }
+      });
+    }
   }

 }

[SentryMan]

Nice work, everything seems in order

[rbygrave]

Great work, thanks !!

[mohamed-abdelnour]

Thank you!

[SentryMan]

Consider yourself welcomed