This repository has been archived by the owner on Aug 8, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
This is a proposal to add the new Docks API to the package as per this issue.
Basically, this is the change from the old pane to the new API, removing the UI that we had to close the runner (the Docks provide the logic required to do this, so packages don't implement it themselves).
Most of the logic that controls the default values has been pushed to the (old) Panel class that acts as a view. As with the new Docks API is possible to have multiple panes in the same dock, I have renamed the class from Panel to AvaPanel as it may be useful to identify the class in an Array (by type).
For consistency and as the UI was already prepared to be shown on the right side of the editor, I have constrained the possible options to just 'left' and 'right' keeping 'right' as the default.
We still have a feature that allows the user to close the pane by clicking
ESC
/core:cancel
when the editor is focused. I wonder if maybe we should get rid completely of this behavior and allow the pane to be closed naturally withCMD-W
.Cheers!
Note: Once the package has been activated and the UI rearranged in some way (moved, resized) these values will override the default. To recover the defaults, this command can be executed:
atom --clear-window-state
Fixes #26