Skip to content
This repository has been archived by the owner on Jan 11, 2019. It is now read-only.

ES6ify the code #24

Merged
merged 3 commits into from
May 30, 2016
Merged

ES6ify the code #24

merged 3 commits into from
May 30, 2016

Conversation

sotojuan
Copy link
Contributor

Fixes #18.

@jamestalmage
Copy link
Contributor

jamestalmage commented May 23, 2016 •
edited
Loading

Hmm.

I wasn't doing use-strict. I wonder if that is your problem somehow.

Use strict is implied for ES2015 modules. Not sure why Babel doesn't just handle that.

sindresorhus
sindresorhus reviewed May 24, 2016
View reviewed changes
cli-utils.js
selectScripts: selectScripts
sortByVersion,
getVersions,
selectScripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ES2015 export.

@sotojuan
Copy link
Contributor Author

All right, phew, fixed a lot of stuff. The rest should just be style fixes from now on.

@jamestalmage
Copy link
Contributor

What was the issue? The use strict line?

@sotojuan
Copy link
Contributor Author

That and I forgot to add more files to the only array in the Babel config 😅

@sotojuan
Copy link
Contributor Author

@sindresorhus What do you think?

@sindresorhus sindresorhus merged commit 6be45dd into avajs:master May 30, 2016
@sindresorhus
Copy link
Member

Looks good. Thanks @sotojuan :)

@DrewML DrewML mentioned this pull request Jul 6, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sotojuan @jamestalmage @sindresorhus