fixup! fixup! fixup! fixup! fixup! fixup! fixup! Add a brand new watcher

avajs · Jul 2, 2023 · 3232df8 · 3232df8
1 parent a4b4ab4
commit 3232df8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/test/watch-mode/basic-functionality.js b/test/watch-mode/basic-functionality.js
@@ -25,7 +25,7 @@ test('ctrl+c interrupts', withFixture('basic'), async (t, fixture) => {
 			const result = await t.try(tt => {
 				tt.regex(stdout, /Exiting due to SIGINT/);
 			});
-			if (platform === 'win32') {
+			if (platform === 'win32' && !result.passed) {
 				result.discard();
 				t.pass('Most likely on Windows we did not capture stdout when the process was killed');
 			} else {

diff --git a/test/watch-mode/helpers/watch.js b/test/watch-mode/helpers/watch.js
@@ -130,7 +130,10 @@ export const withFixture = fixture => async (t, task) => {
 					results.return();
 
 					// Handle outstanding promises in case they reject.
-					if (assertingIdle) await idlePromise;
+					if (assertingIdle) {
+						await idlePromise;
+					}
+
 					await pendingState;
 				}
 			},

diff --git a/test/watch-mode/typescript.js b/test/watch-mode/typescript.js
@@ -6,6 +6,7 @@ import {test, withFixture} from './helpers/watch.js';
 test('waits for external compiler before re-running typescript test files', withFixture('typescript-precompiled'), async (t, fixture) => {
 	await fixture.watch({
 		async 1({stats}) {
+			t.log(stats);
 			await this.assertIdle(async () => {
 				await this.touch('src/test.ts');
 			});
@@ -58,6 +59,7 @@ test('handles inline compilation', withFixture('typescript-inline'), async (t, f
 	await fs.symlink(new URL('../../node_modules', import.meta.url), path.join(fixture.dir, 'node_modules'));
 	await fixture.watch({
 		async 1({stats}) {
+			t.true(stats.passed.length > 0);
 			await this.touch('src/test.ts');
 			return stats.passed;
 		},