Don't leak internal AssertionErrors to user code

Asynchronous `t.throws()` / `t.notThrows()` was the only case where internal AssertionErrors were leaked to user code. Return `undefined` instead.
avajs · Mar 23, 2017 · d56db75 · d56db75
1 parent df54324
commit d56db75
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/lib/assert.js b/lib/assert.js
@@ -166,9 +166,10 @@ function wrapAssertions(callbacks) {
 			};
 
 			if (promise) {
-				const result = promise.then(makeNoop, makeRethrow).then(test);
-				pending(this, result);
-				return result;
+				const intermediate = promise.then(makeNoop, makeRethrow).then(test);
+				pending(this, intermediate);
+				// Don't reject the returned promise, even if the assertion fails.
+				return intermediate.catch(noop);
 			}
 
 			try {
@@ -208,10 +209,10 @@ function wrapAssertions(callbacks) {
 			};
 
 			if (promise) {
-				const result = promise
-					.then(noop, reason => test(makeRethrow(reason)));
-				pending(this, result);
-				return result;
+				const intermediate = promise.then(noop, reason => test(makeRethrow(reason)));
+				pending(this, intermediate);
+				// Don't reject the returned promise, even if the assertion fails.
+				return intermediate.catch(noop);
 			}
 
 			try {