Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch mode filter by filename and by test name #1530

Open
unional opened this issue Sep 23, 2017 · 9 comments
Open

Watch mode filter by filename and by test name #1530

unional opened this issue Sep 23, 2017 · 9 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement new functionality help wanted scope:watch-mode

Comments

@unional
Copy link

unional commented Sep 23, 2017

Issuehunt badges

ava@0.22

borrow the idea from jest:

Watch Usage
 › Press p to filter by a filename regex pattern.
 › Press t to filter by a test name regex pattern.
 › Press q to quit watch mode.
 › Press Enter to trigger a test run.

These two features are very valuable.
They allow me to focus on a subset of tests when I am working on a specific part of the system.

There is a $80.00 open bounty on this issue. Add more on Issuehunt.

@novemberborn
Copy link
Member

Sure.

Does Enter rerun all tests, like r does with AVA? That's quite neat actually.

@unional
Copy link
Author

unional commented Sep 24, 2017

Enter reruns the filtered list of tests. They use a to rerun all tests.

@novemberborn
Copy link
Member

Enter reruns the filtered list of tests. They use a to rerun all tests.

Sounds like we should borrow that too 😉

@sindresorhus sindresorhus changed the title feature: watch mode filter by filename and by test name Watch mode filter by filename and by test name Nov 17, 2017
@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 15, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $80.00 to this issue.


@radasam
Copy link

radasam commented Aug 23, 2022

Hi, Is this still worth working on?

I've noticed there is already an option to pass patterns to the watcher but this is using wildcards, do we want to use this instead of regex?

@novemberborn
Copy link
Member

@radasam it'd be neat, yea! The key change over our current watch mode is being able to take inputs, be it filtering the files or the tests. Whether that has to take the form of Jest' implementation from five years ago, or their current implementation, I do not know. For example a "type some characters and we'll show you a subset of the files / tests that match somehow and then you can run those" could be quite interesting.

@radasam
Copy link

radasam commented Sep 2, 2022

Ok sounds good, I've managed to get something working for filtering by filename, I'm just working on filtering for test names

@ologbonowiwi
Copy link

Is this something that would still be valuable to have?

Do we had any progress or advancements on other stuff that could potentially help implementing this?

@novemberborn
Copy link
Member

Is this something that would still be valuable to have?

I think so.

Do we had any progress or advancements on other stuff that could potentially help implementing this?

The watch implementation was modernized last year, that may make things easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement new functionality help wanted scope:watch-mode
Projects
None yet
Development

No branches or pull requests

6 participants