Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CLI to select a subset of test files, using micromatch-compatible patterns #2281

Closed
novemberborn opened this issue Oct 29, 2019 · 0 comments · Fixed by #2326
Closed

Allow CLI to select a subset of test files, using micromatch-compatible patterns #2281

novemberborn opened this issue Oct 29, 2019 · 0 comments · Fixed by #2326
Assignees
@novemberborn
Labels
breaking requires a SemVer major release enhancement new functionality help wanted scope:globbing
Milestone
v3

Comments

@novemberborn
Copy link
Member

AVA 2 removed glob support from the CLI, under the assumption that user's shells could expand globs instead. This assumption has proven wrong, however.

Currently, positional arguments passed on the CLI are assumed to be test files. They're executed even if they're not matched by the files configuration.

The proposal is to treat the positional arguments as a filter over the configured files. This should use micromatch so glob patterns are supported.

This is a breaking change, since it'll no longer be possible to execute test files that are not matched by the files configuration. We should start with this behavior being an opt-in experiment (see the experiments here).
@novemberborn novemberborn added enhancement new functionality help wanted breaking requires a SemVer major release scope:globbing labels Oct 29, 2019
@novemberborn novemberborn mentioned this issue Oct 29, 2019
Closed
@boenrobot boenrobot mentioned this issue Nov 7, 2019
Closed
@novemberborn novemberborn added this to the v3 milestone Dec 21, 2019
@novemberborn novemberborn self-assigned this Jan 2, 2020
novemberborn added a commit that referenced this issue Jan 2, 2020
@novemberborn
Allow CLI to select a subset of test files
e9e83f9 
Rather than providing paths to specific test files, allow
micromatch-compatible patterns to be provided on the CLI. These then
select a subset of test files.

This does mean that the files patterns in AVA's configuration need to
select all desired test files: you can no longer run a different file.

Fixes #2281.
@novemberborn novemberborn mentioned this issue Jan 2, 2020
Merged
novemberborn added a commit that referenced this issue Jan 2, 2020
@novemberborn
Allow CLI to select a subset of test files
71348e2 
Rather than providing paths to specific test files, allow
micromatch-compatible patterns to be provided on the CLI. These then
select a subset of test files.

This does mean that the files patterns in AVA's configuration need to
select all desired test files: you can no longer run a different file.

Fixes #2281.
novemberborn added a commit that referenced this issue Jan 2, 2020
@novemberborn
Allow CLI to select a subset of test files
a576d0c 
Rather than providing paths to specific test files, allow
micromatch-compatible patterns to be provided on the CLI. These then
select a subset of test files.

This does mean that the files patterns in AVA's configuration need to
select all desired test files: you can no longer run a different file.

Fixes #2281.
novemberborn added a commit that referenced this issue Jan 2, 2020
@novemberborn
Allow CLI to select a subset of test files
83b43a5 
Rather than providing paths to specific test files, allow
micromatch-compatible patterns to be provided on the CLI. These then
select a subset of test files.

This does mean that the files patterns in AVA's configuration need to
select all desired test files: you can no longer run a different file.

Fixes #2281.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novemberborn novemberborn

Labels
breaking requires a SemVer major release enhancement new functionality help wanted scope:globbing
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

Address remaining v3 globbing changes avajs/ava
1 participant
@novemberborn