Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reporting #6

Closed
kevva opened this issue Nov 25, 2014 · 7 comments
Closed

Error reporting #6

kevva opened this issue Nov 25, 2014 · 7 comments
Labels
enhancement new functionality priority

Comments

@kevva
Copy link
Contributor

kevva commented Nov 25, 2014

Should show the err.stack for each failed test imo. Also, we need to sort out the error messages some I think.

@kevva kevva added the enhancement new functionality label Nov 25, 2014
@sindresorhus
Copy link
Member

👍

@kevva kevva changed the title Error reporting TAP compliant output Nov 25, 2014
@kevva
Copy link
Contributor Author

kevva commented Nov 25, 2014

Renamed since error reporting etc will happen in a reporter. Let's convert the output to be TAP compliant first.

@sindresorhus
Copy link
Member

I don't want TAP output as default as it's quite limiting and annoying to work with. I definitely want to support it, but the default reporter should be something nice and simple. My thought was to have a hard-coded reporter and a TAP option, but no reporter option, as TAP has a gadzillion reporters and it might be a good idea not to reinvent the wheel. Thoughts?

@kevva
Copy link
Contributor Author

kevva commented Nov 26, 2014

Hm, yes I agree that it shouldn't be used as default (for the user), but maybe just under the hood. My thought was having it always write TAP output but use a default reporter, looking like the one we use now, if nothing else is specified.

@sindresorhus
Copy link
Member

Having to depend on the TAP output for our default reporter limits what we can do. I honestly see no benefit of doing that. We can easily support TAP too, but I would prefer our default reporter is more tightly coupled so we can make it really good. So good most people won't need another reporter.

@kevva
Copy link
Contributor Author

kevva commented Nov 26, 2014

Alright, that makes it a little easier too :). Let's focus on getting everything else to work nicely first and add TAP support later on.

@sindresorhus
Copy link
Member

Yup, let's build what we need first and make it stable. I've honestly never needed another reporter. We can add bloat like that later on like you said.

@kevva kevva changed the title TAP compliant output Error reporting Nov 26, 2014
@kevva kevva added the priority label Nov 26, 2014
@kevva kevva closed this as completed in 57dbf73 Dec 6, 2014
kevva added a commit that referenced this issue Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new functionality priority
Projects
None yet
Development

No branches or pull requests

2 participants