Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.todo(title, fn) should produce a failure #697

Closed
jamestalmage opened this issue Apr 1, 2016 · 0 comments
Closed

test.todo(title, fn) should produce a failure #697

jamestalmage opened this issue Apr 1, 2016 · 0 comments

Comments

@jamestalmage
Copy link
Contributor

Overview:

My understanding of the skip vs todo vs failing API was:

  1. test.skip([title], fn) - A test function is provided, but it is skipped(i.e. fn is never called). Common use: removing a failing test while you are in the middle of refactoring. People probably shouldn't be checking test.skip tests into their master branch (especially once test.failing is implemented). Title is optional, just like the normal test method.
  2. test.todo(title) - No test function is allowed, but a title is required. Common use: documenting future tests (and maybe features) that need to be written.
  3. test.failing([title], fn) - Proposed in A way to submit tests that should fail.  #673- Optional title, test function is required and will be run (but is expected to fail). Common use: allow users to create PR's that reproduce the problem. Reporting bugs in a way that does not break the build.

Issue:

Right now the API for 2 is more like: test.todo(title, [fn]) - title is required, but fn is optional (and ignored).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant