Precompile helpers #1078

vadimdemedes · 2016-10-15T15:37:54Z

Fixes #720 and potentially #1049.

Lack of this feature has been bugging me for a long time, glad I've finally found a time to fix it. It's still WIP, need to:

Submit a PR to ava-files to support findHelpers() (currently named as findTestDependencies()).
Fix tests.
Write new tests.

As for #1049 (external macros are not precompiled), we could add a special glob for that, like **/macros/** to precompile those files as well.

novemberborn · 2016-10-16T12:06:58Z

Good start! This compiles the helpers as if they were test files, right? That seems correct to me.

Let's see where that gets us before doing anything else for macros.

vadimdemedes · 2016-10-19T20:40:30Z

This compiles the helpers as if they were test files, right? That seems correct to me.

Yep, exactly.

Let's see where that gets us before doing anything else for macros.

Yes for sure, that is unrelated to this PR.

sindresorhus · 2016-10-22T05:18:38Z

api.js

+
+	return new AvaFiles({cwd: this.options.resolveTestsFrom})
+		.findTestDependencies()
+		.map(function (file) { // eslint-disable-line array-callback-return


Why use .map if you're not actually going to map anything?

I was using it as a way to async iterate the items. Is there another bluebird method that does that?

novemberborn

Do we foresee people wanting to disable this behavior?

novemberborn · 2016-10-23T15:18:18Z

test/api.js

@@ -705,9 +705,16 @@ function generateTests(prefix, apiCreator) {
 	test(prefix + 'caching is enabled by default', function (t) {
 		t.plan(3);
 		rimraf.sync(path.join(__dirname, 'fixture/caching/node_modules'));
+
+		var prevCwd = process.cwd();
+		process.chdir(path.join(__dirname, 'fixture/caching'));


Why this change?

Tests are being run from the root, so AVA finds and precompiles helpers and fixtures from the test folder (e.g. test/fixture/ignored-dirs/helpers/test.js).

That's why I change the cwd to make it look like the tests are being executed from that dir. I think it's actually what each test should do.

The pkgDir and resolveTestsFrom directories can be passed to Api though. That's how its meant to be used, implicit defaults aside. We shouldn't need to change the working directory of the tap process.

Thanks for the tip!

novemberborn · 2016-10-23T15:33:00Z

Do we foresee people wanting to disable this behavior?

Specifically transpiling fixtures seems fraught.

vadimdemedes · 2016-10-24T19:34:20Z

Specifically transpiling fixtures seems fraught.

Could you elaborate on this? I don't quite understand the reasoning.

novemberborn · 2016-10-25T08:20:51Z

Helpers should contain logic to make it easier to write test. Fixtures contain all sorts of files that relate to your test. If you're testing a Babel plugin you may write .js fixtures that you're using to exercise your tests. Those should not be transpiled.

sindresorhus · 2016-11-04T15:51:45Z

@vdemedes What's your use-case for transpiling fixtures? I'm leaning towards @novemberborn's argument.

vadimdemedes · 2016-11-04T20:28:24Z

My thinking was that everything that resides under test/ belongs to AVA, so it should take care of those files and provide its features (power-assert, ES6, etc) to them as well.

However, @novemberborn's reasoning about fixtures relation to tests does make sense to me now. I will correct this PR and the one in ava-files as well.

Snugug · 2016-12-16T16:34:48Z

w/r/t #1049, I've just installed this branch and ran against an external macro, and it did not appear to resolve the issue that powerAssert is not applied to those tests

vadimdemedes · 2016-12-27T20:47:17Z

@Snugug only files with names starting with _ and located in helpers/ folders get transpiled in this PR. In the issue you mentioned the files are located in macros/ folder, right?

sindresorhus · 2017-01-05T12:05:19Z

Code looks good to me, but needs to be added to the readme.

vadimdemedes · 2017-01-05T13:40:11Z

Added a small note to readme: https://github.com/avajs/ava/pull/1078/files#diff-0730bb7c2e8f9ea2438b52e419dd86c9R738.

sindresorhus · 2017-01-07T08:45:16Z

Yay! This one is going to be super useful 💃

Thanks for finishing this up Vadim 👌

sindresorhus force-pushed the master branch 2 times, most recently from 4bc021e to 476c653 Compare October 18, 2016 03:23

sindresorhus reviewed Oct 22, 2016

View reviewed changes

vadimdemedes force-pushed the precompile-helpers-fixtures branch from 600f1d3 to b5ace1c Compare October 23, 2016 09:16

vadimdemedes mentioned this pull request Oct 23, 2016

Add findTestHelpers() to find helpers and fixtures avajs/ava-files#8

Merged

vadimdemedes force-pushed the precompile-helpers-fixtures branch 3 times, most recently from 9303025 to f0f25b5 Compare October 23, 2016 12:44

novemberborn reviewed Oct 23, 2016

View reviewed changes

vadimdemedes force-pushed the precompile-helpers-fixtures branch from f0f25b5 to fe3eec1 Compare November 6, 2016 11:58

sindresorhus force-pushed the master branch 4 times, most recently from 8610723 to 4acb78f Compare November 22, 2016 17:46

vadimdemedes force-pushed the precompile-helpers-fixtures branch from fe3eec1 to 187b0a6 Compare December 12, 2016 20:37

vadimdemedes changed the title ~~[WIP] Precompile helpers and fixtures~~ Precompile helpers and fixtures Dec 12, 2016

vadimdemedes changed the title ~~Precompile helpers and fixtures~~ Precompile helpers Dec 12, 2016

vadimdemedes force-pushed the precompile-helpers-fixtures branch from 187b0a6 to 3e8523a Compare December 27, 2016 20:51

precompile helpers and fixtures

c3fe5ec

vadimdemedes force-pushed the precompile-helpers-fixtures branch from 3e8523a to c3fe5ec Compare January 5, 2017 13:39

Update readme.md

1e90484

sindresorhus merged commit 410cb8d into master Jan 7, 2017

sindresorhus deleted the precompile-helpers-fixtures branch January 7, 2017 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Precompile helpers #1078

Precompile helpers #1078

vadimdemedes commented Oct 15, 2016 •

edited

Loading

novemberborn commented Oct 16, 2016

vadimdemedes commented Oct 19, 2016

sindresorhus Oct 22, 2016

vadimdemedes Oct 22, 2016

novemberborn left a comment

novemberborn Oct 23, 2016

vadimdemedes Oct 24, 2016

novemberborn Oct 30, 2016

vadimdemedes Nov 6, 2016

novemberborn commented Oct 23, 2016

vadimdemedes commented Oct 24, 2016

novemberborn commented Oct 25, 2016

sindresorhus commented Nov 4, 2016

vadimdemedes commented Nov 4, 2016

Snugug commented Dec 16, 2016

vadimdemedes commented Dec 27, 2016

sindresorhus commented Jan 5, 2017

vadimdemedes commented Jan 5, 2017

sindresorhus commented Jan 7, 2017 •

edited

Loading

Precompile helpers #1078

Precompile helpers #1078

Conversation

vadimdemedes commented Oct 15, 2016 • edited Loading

novemberborn commented Oct 16, 2016

vadimdemedes commented Oct 19, 2016

sindresorhus Oct 22, 2016

Choose a reason for hiding this comment

vadimdemedes Oct 22, 2016

Choose a reason for hiding this comment

novemberborn left a comment

Choose a reason for hiding this comment

novemberborn Oct 23, 2016

Choose a reason for hiding this comment

vadimdemedes Oct 24, 2016

Choose a reason for hiding this comment

novemberborn Oct 30, 2016

Choose a reason for hiding this comment

vadimdemedes Nov 6, 2016

Choose a reason for hiding this comment

novemberborn commented Oct 23, 2016

vadimdemedes commented Oct 24, 2016

novemberborn commented Oct 25, 2016

sindresorhus commented Nov 4, 2016

vadimdemedes commented Nov 4, 2016

Snugug commented Dec 16, 2016

vadimdemedes commented Dec 27, 2016

sindresorhus commented Jan 5, 2017

vadimdemedes commented Jan 5, 2017

sindresorhus commented Jan 7, 2017 • edited Loading

vadimdemedes commented Oct 15, 2016 •

edited

Loading

sindresorhus commented Jan 7, 2017 •

edited

Loading