Fix snapshot report merging. #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `newLength` to `checkPosition` to make the function clearer. At the end of the loop `checkPosition` points to the last index that does not contain a line ending, so add one to include it. Fixes #1848
novemberborn
added a commit
that referenced
this pull request
Oct 21, 2018
I reckon this fixes a regression introduced in #1852.
novemberborn
added a commit
that referenced
this pull request
Oct 22, 2018
I reckon this fixes a regression introduced in #1852.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
newLengthtocheckPositionto make the function clearer.At the end of the loop
checkPositionpoints to the last index thatdoes not contain a line ending, so add one to include it.
Fixes #1848