Fix circular references on assertions before sending across the wire. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestalmage
force-pushed
the
same-with-circular
branch
from
095194b
to
091c249
Compare
|
😠 Windows and Node 0.10 are quickly becoming annoying. |
jamestalmage
force-pushed
the
same-with-circular
branch
2 times, most recently
from
97292fd
to
42e8747
Compare
|
It looks like AppVeyor is having some issues. Those pass just fine in my Windows VM. It's not making it through npm install on AppVeyor |
jamestalmage
force-pushed
the
same-with-circular
branch
from
45fc3cd
to
8201d69
Compare
add test to prove failed assertions do not choke on circular data structures add test fixture with circular reference (to make sure it makes it across the wire) switch from serialize-error to destroy-circular
jamestalmage
force-pushed
the
same-with-circular
branch
from
8201d69
to
2f16758
Compare
|
What the heck? It was green after rebase! All I did was squash! |
|
Crap. Adding the We have intermittent test failures on CI that I can not reproduce locally at all. |
|
@sindresorhus I can drop the |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We serialize and send copies of assertions errors across the wire on failure.
If
assertionError.actual, orassertionError.expectedhave a circular reference, this causes a problem whenprocess.sendconverts to JSON.This replaces
serialize-errorwithdestroy-circular. I found one tiny bug with their implementation, but it seems good otherwise.