Clean up forking and messages #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var EventEmitter = require('events').EventEmitter; | ||
| var Promise = require('bluebird'); | ||
| var hasFlag = require('has-flag'); | ||
| var util = require('util'); |
There was a problem hiding this comment.
I prefer to have builtin requires grouped first.
There was a problem hiding this comment.
Np ;) I just order stuff by module name length in my projects.
vadimdemedes
force-pushed
the
cleanup-fork
branch
4 times, most recently
from
7426ab8
to
d6b932b
Compare
|
@jamestalmage thanks for the tip! |
vadimdemedes
force-pushed
the
cleanup-fork
branch
from
d6b932b
to
6aea81d
Compare
vadimdemedes
force-pushed
the
cleanup-fork
branch
from
6aea81d
to
33b5d2b
Compare
vadimdemedes
pushed a commit
that referenced
this pull request
Nov 17, 2015
Clean up forking and messages
|
Nice! You taking a break now, or are you moving on to a major refactor? |
|
No no, I want to clean up everything, all files and tests, then move on to refactoring. |
|
Leave |
|
Unfortunately, code interferes between files, so I can't guarantee I can leave unaffected runner.js. I was hoping to do it all in one wave, so that I don't wait for anyone else (that is why we cleaned up our PR queue) and after that, any suggestions and contributions are welcome ;) |
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean up kind of PR, not refactoring.