Improve ESM support detect #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
force-pushed
the
improve-esm-support
branch
from
deb1264
to
c28b2f3
Compare
fisker
force-pushed
the
improve-esm-support
branch
2 times, most recently
from
a3884d3
to
ba66367
Compare
fisker
force-pushed
the
improve-esm-support
branch
from
ba66367
to
7242ec8
Compare
| // Lazily determine support since this prints an experimental warning. | ||
| const supportsESM = async () => { | ||
| try { | ||
| await import('data:text/javascript,'); |
There was a problem hiding this comment.
Ha that's neat. Saves us from having a weird file in the package.
fisker
commented
Feb 20, 2020
| isESMSupported = await supportsESM(); | ||
| } | ||
|
|
||
| if (isESMSupported) { | ||
| return import(pathToFileURL(ref)); |
There was a problem hiding this comment.
Do we need this pathToFileURL?
There was a problem hiding this comment.
Seems need for Node.js 13 on windows https://github.com/avajs/ava/pull/2404/checks?check_run_id=457268243
This reverts commit 4ec286d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
lib/esm-probe.mjsfile by a dataURL,and we don't care about theimportresult, we don't have to waitCache the detect result, so we don't have to wait for a microtask everytime
@arlac77