Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More source map work #2859

Merged
merged 3 commits into from Oct 17, 2021
Merged

More source map work #2859

merged 3 commits into from Oct 17, 2021

Conversation

novemberborn
Copy link
Member

@novemberborn novemberborn commented Oct 4, 2021 •
edited

Fixes #2844

  • Convert lib/worker/line-numbers to ESM
  • Add full source map support to line number selection
  • Remove convert-source-map from snapshot manager

@novemberborn
Convert lib/worker/line-numbers to ESM
df53ca9 
Only lazily load Acorn using require(), upgrade callsites to latest version.
@novemberborn
Add full source map support to line number selection
70c51f0
@novemberborn novemberborn marked this pull request as ready for review October 17, 2021 15:40
@novemberborn
Use built-in source map support for determining snapshot location
a4bd1bb 
Incidentally, this means the snap file is now properly tracked as a
dependency.
@novemberborn novemberborn merged commit 4e703ac into main Oct 17, 2021
@novemberborn novemberborn deleted the source-maps-take-two branch October 17, 2021 16:07
@novemberborn novemberborn mentioned this pull request Oct 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove convert-source-map dependency
1 participant
@novemberborn