test-ended rule does not like macros:

[jamestalmage]

function cbMacro(t, input, expected) {
  fn(input, output => {
     t.is(output, expected);
     t.end();
  });
}

test.cb(cbMacro, 'foo', 'FOO'); // <-- violates the rule, but it shouldn't.
test.cb(cbMacro, 'bar', 'BAR');

gmartigny earned $20.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[IssueHuntBot]

@IssueHunt has funded $20.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[GMartigny]

How should the plugin react to this kind of case ?

I see two distinct possibilities:

test.cb(macro);

test.cb(t => {
  macro();
});

In the first case, we can "simply" disable the warning if test.cb first argument is a reference (we can at least check that the reference exists).

In the second case however, assuming that any function calls disable the rule renders it irrelevant. Most of the time (all the time ?), a test.cb will a call a function to test.

[novemberborn]

In the first case, we can "simply" disable the warning if test.cb first argument is a reference (we can at least check that the reference exists).

This sounds good to me.

[IssueHuntBot]

@sindresorhus has rewarded $18.00 to @GMartigny. See it on IssueHunt

• 💰 Total deposit: $20.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $2.00