Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON schema default in rules #214

Closed
sindresorhus opened this issue Feb 16, 2019 · 3 comments · Fixed by #258
Closed

Use JSON schema default in rules #214

sindresorhus opened this issue Feb 16, 2019 · 3 comments · Fixed by #258
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Member

sindresorhus commented Feb 16, 2019

Issuehunt badges

Instead of manual Object.assign. See: eslint/eslint@550de1e


IssueHunt Summary

mrhen mrhen has been rewarded.

Sponsors (Total: $40.00)

Tips

@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@GMartigny
Copy link
Contributor

Problem is, the default keyword doesn't seems to work with unnamed options (outside of a properties keyword).

eg: Adding a default: 5 to

const schema = [{
type: 'integer'
}];

don't inject 5 in an empty ([]) options list.

The specifications don't say anything about this case.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jun 11, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @MrHen. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
3 participants