-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node to v 16 since v12 is deprecated #11
base: master
Are you sure you want to change the base?
Conversation
`Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: avakar/create-deployment`
@avakar Any reason why this is not merged yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, looks good to me. Let's merge this PR asap.
@avakar Is there anything preventing this PR from being merged? Let me know if I can help in any way. Thanks! |
@@ -56,5 +56,5 @@ outputs: | |||
description: The API url of the deployment statuses. | |||
|
|||
runs: | |||
using: 'node12' | |||
using: 'node16' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be Node 20 now to avoid the deprecation warnings: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been 1.5 years, I sadly don't think this PR will get merged 😢
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: avakar/create-deployment